On Tue, 3 Dec 2024 11:42:41 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> uncomment a test in XSLTFunctionsTest > > test/jaxp/javax/xml/jaxp/unittest/transform/XSLTFunctionsTest.java line 162: > >> 160: * @param expectedResult Expected transformation result >> 161: **/ >> 162: //@Test(dataProvider = "document") > > Is there a reason you have this commented out? If the test is not needed, it > should be removed or use the 'disable' element and add a comment as to why > this is disabled Good catch - it was commented out for debugging the other tests. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22504#discussion_r1868156676