On Tue, 3 Dec 2024 01:04:30 GMT, Joe Wang <[email protected]> wrote:
> Disables XSLT and XPath Extension Functions by default, setting
> jdk.xml.enableExtensionFunctions to false.
>
> Adjusted tests accordingly.
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages.java
line 284:
> 282:
> 283: {BasisLibrary.UNALLOWED_EXTENSION_ELEMENT_ERR,
> 284: "Use of the extension function ''{0}'' is not allowed when
> extension "
Is it correct that "element" has been replaced by "function" here?
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java
line 218:
> 216: * <p>State of secure processing feature.</p>
> 217: */
> 218: private boolean _isNotSecureProcessing = false;
An unfortunate double-negative state for the feature.
(Makes it hard to understand and easy to get confused about).
test/jaxp/javax/xml/jaxp/libs/jaxp/library/JAXPTestUtilities.java line 71:
> 69: isWindows = true;
> 70: }
> 71: };
Could be a direct assignment and final:
Suggestion:
public static final boolean isWindows =
System.getProperty("os.name").contains("Windows");
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22504#discussion_r1868124959
PR Review Comment: https://git.openjdk.org/jdk/pull/22504#discussion_r1868128958
PR Review Comment: https://git.openjdk.org/jdk/pull/22504#discussion_r1868136612
