On Sat, 30 Nov 2024 19:43:52 GMT, Joe Wang <jo...@openjdk.org> wrote:

>> src/java.xml/share/classes/module-info.java line 484:
>> 
>>> 482:  * <td style="text-align:center">
>>> 483:  * xhtml-attribs-1.xsd xhtml-copyright-1.xsd xhtml-datatypes-1.xsd 
>>> xhtml-framework-1.xsd<br>
>>> 484:  * xhtml11-model-1.xsd xhtml11-modules-1.xsd xhtml11.xsd
>> 
>> I suspect the second column, meaning the list of files for each source, 
>> would be easier to read if listed vertically rather than horizontally.
>> 
>> Otherwise this update looks a quite good and a big help in the long term 
>> effort to change the default in the future to not allow external access when 
>> processing XML.
>
> Thanks Alan. Changed the file column to list files vertically. Also removed 
> the referenced module files for xhtml11.xsd since only the main is necessary. 
> There are also many more secondarily referenced module files.

Thank you, the table in the "JDK built-in Catalog" section looks much better 
now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22465#discussion_r1864763789

Reply via email to