On Mon, 2 Dec 2024 18:14:42 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> list files vertically > > src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java > line 1217: > >> 1215: resourceIdentifier.setExpandedSystemId(expandedSystemId); >> 1216: xmlInputSource = >> fEntityResolver.resolveEntity(resourceIdentifier); >> 1217: resolveByResolver = (xmlInputSource != null) ? true : >> false; > > The "? true : false" isn't needed; the boolean result is sufficient. Thanks Roger. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22465#discussion_r1866542575