On Sat, 30 Nov 2024 19:47:15 GMT, Joe Wang <jo...@openjdk.org> wrote:
>> Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > list files vertically lookg good src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java line 1217: > 1215: resourceIdentifier.setExpandedSystemId(expandedSystemId); > 1216: xmlInputSource = > fEntityResolver.resolveEntity(resourceIdentifier); > 1217: resolveByResolver = (xmlInputSource != null) ? true : false; The "? true : false" isn't needed; the boolean result is sufficient. ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22465#pullrequestreview-2473520264 PR Review Comment: https://git.openjdk.org/jdk/pull/22465#discussion_r1866361223
