On Wed, 20 Nov 2024 01:47:34 GMT, Taizo Kurashige <d...@openjdk.org> wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic" >> executed with "chcp 65001". This ensures that the encoding is UTF8 and that >> the English message "No Instance(s) Available." is output on localized >> windows platforms. >> >> I have referred to the following for how to use chcp: >> ・chcp | Microsoft Learn at >> https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/chcp >> ・Code Page Identifiers - Win32 apps | Microsoft Learn at >> https://learn.microsoft.com/en-us/windows/win32/intl/code-page-identifiers >> >> After fix, I ran tools/jpackage tests importing jdk.jpackage.test.Executor >> or jdk.jpackage.test.WindowsHelper.killAppLauncherProcess on Windows Server >> 2019 (Japanese and English locales). I confirmed that they pass. >> >> Thanks > > Taizo Kurashige has updated the pull request incrementally with one > additional commit since the last revision: > > Fix indent Changes requested by asemenyuk (Reviewer). test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java line 487: > 485: List::stream).toList(); > 486: > 487: return String.format(format, printCommandLine(cmdline), > cmdline.size() + 1); `cmdline.size() + 1` seems to be wrong. It should be `cmdline.size()`. ` + 1` was needed previously when was applied to the `args.size()` that didn't count the executable. Sorry, I oversaw this thing in my patch. ------------- PR Review: https://git.openjdk.org/jdk/pull/22142#pullrequestreview-2447254472 PR Review Comment: https://git.openjdk.org/jdk/pull/22142#discussion_r1849441641
