On Fri, 15 Nov 2024 09:43:15 GMT, Taizo Kurashige <d...@openjdk.org> wrote:
> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic" > executed with "chcp 65001". This ensures that the encoding is UTF8 and that > the English message "No Instance(s) Available." is output on localized > windows platforms. > > I have referred to the following for how to use chcp: > ・chcp | Microsoft Learn at > https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/chcp > ・Code Page Identifiers - Win32 apps | Microsoft Learn at > https://learn.microsoft.com/en-us/windows/win32/intl/code-page-identifiers > > After fix, I ran tools/jpackage tests importing jdk.jpackage.test.Executor or > jdk.jpackage.test.WindowsHelper.killAppLauncherProcess on Windows Server 2019 > (Japanese and English locales). I confirmed that they pass. > > Thanks test/jdk/tools/jpackage/helpers/jdk/jpackage/test/WindowsHelper.java line 265: > 263: } > 264: > 265: String[] headers = Stream.of(output.get(1).split("\\s+", 2)).map( Why look up the headers in the _second_ line of the output? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22142#discussion_r1843736128
