On Tue, 22 Oct 2024 15:32:45 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> My proposal was to use it in this file (iterator.inline.hpp) and not >> iterator.hpp. I see no need to route this through the .cpp file. > > iterator.inline.hpp is included by many cpp file (580 out of 1409 .o files in > hotspot), so I don't want to add aotLinkedClassBulkLoader.hpp to it. > > > scanning 580 iterator.inline.hpp > 2 found 580 oop.inline.hpp > 3 found 580 zIterator.inline.hpp > 4 found 580 zBarrierSet.inline.hpp > 5 found 60 g1OopClosures.inline.hpp > 6 found 7 g1FullGCOopClosures.inline.hpp > 7 found 5 psPromotionManager.inline.hpp
>From what I can tell it is a tiny header with very few dependencies. I don't >think we gain much by trying to prevent it from being include. I would >strongly prefer to have cleaner code in iterator.hpp/cpp than trying to get >rid of that include. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21143#discussion_r1811012268
