On Thu, 17 Oct 2024 08:36:53 GMT, John R Rose <jr...@openjdk.org> wrote:
> I read through it fairly thoroughly. I made a lot of suggestions. Rather than > edit comments into lots of spots in this PR, I made the following patch file. > [aot-indy-21143-commentary.diff.txt](https://github.com/user-attachments/files/17408940/aot-indy-21143-commentary.diff.txt) +bool InstanceKlass::is_enum_subclass(bool direct_only) const { + InstanceKlass* s = java_super(); + return (s == vmClasses::Enum_klass() || + (s != null && s->java_super() == vmClasses::Enum_klass())); +} Just happened to notice you aren't checking `direct_only`. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21143#issuecomment-2421125248
