On Wed, 16 Oct 2024 18:01:28 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adjusting the concise help as suggested: 'using main class of a JAR >> archive' and '<JarFile>.jar'/'<SourceFile>.java' > > src/java.base/share/native/libjli/java.c line 1924: > >> 1922: */ >> 1923: static void >> 1924: PrintUsage(JNIEnv* env, jboolean doXUsage, jboolean conciseUsage) > > This would be cleaner to replace the booleans with an enum (concise, X, full). > Since conciseUsage overrides doXusage, then it should preceed Xusage in the > argument list. Thanks. I've attempt to do that here: https://github.com/openjdk/jdk/pull/21411/commits/1fe578185e5c8f575dabef5c5fb869e93f218c72 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21411#discussion_r1808470949
