On Thu, 17 Oct 2024 06:02:50 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adjusting the concise help as suggested: 'using main class of a JAR
>> archive' and '<JarFile>.jar'/'<SourceFile>.java'
>
> src/java.base/share/classes/sun/launcher/resources/launcher.properties line
> 247:
>
>> 245: \ --module-path <module path>\n\
>> 246: \ a "{0}"-separated list of directories and JAR archives to search
>> for modules\n\n\
>> 247: \For more details about this launcher: java --help\n\
>
> Hello Jan, perhaps we should avoid the use of "launcher" here and instead
> reword it as:
>
> For additional help on usage: java --help\n\
Sorry, but it feels a bit incomplete - it does not say usage of what. I don't
quite see the issue with the word "launcher". The `java` command is a launcher
for user programs, is it not?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21411#discussion_r1808234314
