On Sat, 12 Oct 2024 00:45:40 GMT, Johny Jose <d...@openjdk.org> wrote:

>> Timezone data 2024b changes
>
> Johny Jose has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Review changes

Besides small comment, looks correct to me, thanks for the changes.

test/jdk/sun/util/calendar/zi/TestZoneInfo310.java line 282:

> 280:                                willGMTOffsetChange.getBoolean(tz));
> 281:     }
> 282: 

Patch will be cleaner if we remove the line change (L 282-283) as well.

-------------

Marked as reviewed by jlu (Committer).

PR Review: https://git.openjdk.org/jdk/pull/21265#pullrequestreview-2364803270
PR Review Comment: https://git.openjdk.org/jdk/pull/21265#discussion_r1798009641

Reply via email to