On Mon, 30 Sep 2024 14:03:15 GMT, Johny Jose <d...@openjdk.org> wrote:
> Timezone data 2024b changes
src/java.base/share/classes/java/time/ZoneId.java line 189:
> 187: * {@link #of(String, Map)} factory method.
> 188: * <p>
> 189: * This map contains a mapping of the IDs that is in line with TZDB
> 2005r and
I believe this file needs a copyright year bump.
src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java line 288:
> 286: aliases.put("MST", "America/Phoenix");
> 287: }
> 288: aliases.put("HST", "Pacific/Honolulu");
Looks correct to me, since "HST" to "Pacific/Honolulu" link is same for
`USE_OLDMAPPING` as well as 2024b update.
test/jdk/sun/util/calendar/zi/TestZoneInfo310.java line 290:
> 288:
> 289: if (l1.equals(l2)) {
> 290: System.out.println("no diff");
Is this needed? IIUC `diff` is only called if the array contents are not equal.
test/jdk/sun/util/resources/TimeZone/Bug4848242.java line 35:
> 33: import java.text.DateFormatSymbols;
> 34:
> 35: public class Bug4848242 {
This test needs a copyright year bump. (Applies to any other tests as well).
We also might want to update the summary, since it should no longer display MET
and MEST, but rather CET and CEST.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21265#discussion_r1783319052
PR Review Comment: https://git.openjdk.org/jdk/pull/21265#discussion_r1783317888
PR Review Comment: https://git.openjdk.org/jdk/pull/21265#discussion_r1783330388
PR Review Comment: https://git.openjdk.org/jdk/pull/21265#discussion_r1783320110
