On Tue, 1 Oct 2024 18:40:56 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Johny Jose has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review changes
>
> test/jdk/sun/util/calendar/zi/TestZoneInfo310.java line 290:
>
>> 288:
>> 289: if (l1.equals(l2)) {
>> 290: System.out.println("no diff");
>
> Is this needed? IIUC `diff` is only called if the array contents are not
> equal.
Since `diff` is a generic debug function, equality check needed to be in the
function itself. Anyway, I wrote this code for purely debug purpose, so can be
removed altogether.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21265#discussion_r1792238867
