On Wed, 6 Mar 2024 01:58:26 GMT, Ioi Lam <ik...@openjdk.org> wrote:
>> I meant the following. Just the last line #94 needs to be changed - shift
>> one space to the left after `bool`.
>>
>> static bool is_dumping_heap()
>> NOT_CDS_JAVA_HEAP_RETURN_(false);
>> static void stop_dumping_full_module_graph(const char* reason = nullptr)
>> NOT_CDS_JAVA_HEAP_RETURN;
>> static bool is_dumping_full_module_graph() { return
>> CDS_ONLY(_is_dumping_full_module_graph) NOT_CDS(false); }
>> static void stop_using_full_module_graph(const char* reason = nullptr)
>> NOT_CDS_JAVA_HEAP_RETURN;
>> static bool is_using_full_module_graph()
>> NOT_CDS_JAVA_HEAP_RETURN_(false);
>
> I wanted line 94 to align the "using_full_module_graph" part with the
> function at line 93.
In that case, it looks good.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18095#discussion_r1513723384
