On Wed, 1 Nov 2023 00:06:35 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
> Test thread factory is a mode similar to VM flags and should not be used in > ProcessTools.createLimitedTestJavaProcessBuilder(). Only > createTestJavaProcessBuilder() should use it like jtreg VM options. > > Adding the test thread factory requires the injection of arguments in the > middle of the list. I don't think it makes sense to modify arguments in > several places so I replaced it with the flag isLimited and moved all > modifications in createJavaProcessBuilder(). > > Testing tier1-5. It seems like the code would be cleaner if you moved the threadFactory injection to `createTestJavaProcessBuilder`. ------------- Changes requested by stefank (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16442#pullrequestreview-1707671922
