On Sat, 11 Mar 2023 02:20:31 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> @JornVernee: Thanks! I've merged in your changes. TestArrayStructs is not >> yet completely working. I will need to investigate. I think I've done most >> other things you had requested. You may want to take a look at my recent >> commits. > > @TheRealMDoerr I've been keeping up with the changes you're making. I just > have to look at the new test for HFA's you've added you added (next week). > > Besides fixing the TestArrayStructs test, do you have anything else you still > want to add to this PR? @JornVernee: I guess I should add a couple of Upcalls to my new test. Otherwise, I have only planned to fix `TestArrayStructs`. Further changes (and maybe new tests) can still get done when working on Big Endian / AIX or when there is a demand. I'm currently wondering about the `TestArrayStructs` failures. Passing arrays with up to 7 elements seems to work fine. When I pass 8 elements, the last element of `capturedArgs` gets observed as 0. When I pass more than 8 elements, element 5 and 6 of `capturedArgs` get observed as 0. `DowncallLinker.invokeInterpBindings` has the correct `args`, but `UpcallLinker.invokeInterpBindings` doesn't receive the correct values as `lowLevelArgs`. They contain the wrong zeros. The remaining elements look correct. Do you have an idea what could be going wrong? Otherwise, I'll have to continue debugging. ------------- PR: https://git.openjdk.org/jdk/pull/12708
