On Wed, 22 Feb 2023 20:25:07 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor cleanup.
>
> src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/CallArranger.java
> line 81:
>
>> 79: new VMStorage[] { f1, f2, f3, f4, f5, f6, f7, f8 }, // FP output
>> 80: new VMStorage[] { r0, r2, r3, r4, r5, r6, r7, r8, r9, r10, r11,
>> r12 }, // volatile GP
>> 81: new VMStorage[] { f0, f1, f2, f3, f4, f5, f6, f7, f8, f9, f10,
>> f11, f12, f13 }, // volatile FP
>
> Note that argument registers are assumed volatile, so they don't have to be
> duplicated here.
Removed.
> src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/linux/LinuxPPC64CallArranger.java
> line 33:
>
>> 31: * PPC64 CallArranger specialized for Linux ABI.
>> 32: */
>> 33: public class LinuxPPC64CallArranger extends CallArranger {
>
> I don't really see the point in having a separate subclass with
> `CallArranger` being abstract, unless you are planning to add other
> implementations later?
>
> (edit: see also later comment in CallArranger
> https://github.com/openjdk/jdk/pull/12708#discussion_r1120753657)
AIX support will need to get implemented, yet. I guess @backwaterred will work
on it.
-------------
PR: https://git.openjdk.org/jdk/pull/12708
