On Mon, 6 Mar 2023 16:38:37 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> @JornVernee: Thanks a lot for your detailed review! I have quite a few TODOs >> which include: >> - Include my tests for the HFA corner cases. >> - Try to improve handling of the overlapping registers as you suggested. >> - Check nesting of HFA. >> >> There will surely be more when looking into Big Endian support after merging >> with your recent work on >> https://github.com/openjdk/panama-foreign/compare/foreign-memaccess+abi...JornVernee:panama-foreign:OOB >> We should get rid of oversized accesses on PPC64, too. >> Thanks for sharing your plans to intrisify `linkToNative` in C2 later. I >> guess we should do more preparation work on all platforms when that gets >> addressed. > > @TheRealMDoerr I've moved the support for structs/unions that are not a power > of 2 in size to this repo, so you should be able to merge the master branch > to get it now. @JornVernee: Thanks! I've merged in your changes. TestArrayStructs is not yet completely working. I will need to investigate. I think I've done most other things you had requested. You may want to take a look at my recent commits. ------------- PR: https://git.openjdk.org/jdk/pull/12708