On Sat, 6 Aug 2022 08:08:43 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this change which proposes to fix > https://bugs.openjdk.org/browse/JDK-8290041? > > As noted by the reporter, the current implementation is buggy since the > calculation can result in a different value of the hashcode depending on the > order of iteration of the `Modifier`s. The commit in this PR changes that > computation to produce consistent result irrespective of the order in which > the `Modifier`s (enum) is iterated upon. > > A new test has been added which reproduces the issue and verifies the fix. This pull request has now been integrated. Changeset: 4cc6cb9d Author: Jaikiran Pai <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/4cc6cb9d9ddbcc540baac7b81398f2af83f93340 Stats: 123 lines in 2 files changed: 117 ins; 3 del; 3 mod 8290041: ModuleDescriptor.hashCode is inconsistent Reviewed-by: alanb ------------- PR: https://git.openjdk.org/jdk/pull/9790
