On Wed, 10 Aug 2022 15:23:12 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> incorporate review comments and add more testing > > test/jdk/java/lang/module/ModuleDescriptorHashCodeTest.java line 76: > >> 74: // important to use Set.of() (i.e. backed by immutable set) to >> reproduce the issue >> 75: final Set<ModuleDescriptor.Opens.Modifier> mod1 = Set.of( >> 76: ModuleDescriptor.Opens.Modifier.SYNTHETIC, >> ModuleDescriptor.Opens.Modifier.MANDATED); > > These should probably be "mods1" and "mods2" rather than "mod1" and "mod2" as > they are a set of modifiers rather than a single modifier. Fixed in the latest version of this PR. ------------- PR: https://git.openjdk.org/jdk/pull/9790
