SEZ9 commented on issue #12723: URL: https://github.com/apache/seatunnel/issues/12723#issuecomment-6117188365
Thanks for the detailed proposal, and for the follow-up acknowledging the review points. A few things are still unclear to me: 1. How do `fetch_size` and `max_results` interact? Since `max_results` is the API page size and `fetch_size` is the internal buffer size, please describe what happens when they differ. 2. Will the source support parallel reads (multiple splits), or will it be a single-split read? Please state this explicitly so the delivery/snapshot semantics can be reviewed against it. 3. What does the source emit when `dry_run` is enabled? Please clarify whether it produces any rows, and how the estimated bytes/cost are surfaced to the user. 4. How will the SeaTunnel schema be derived: from table metadata (in `dataset_id` + `table_id` mode) or from the query job result schema (in `query` mode)? No need to restate the type-mapping or option-rule plans; those are clear. Looking forward to the linked PR. <!-- streview-comment:1693 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
