SEZ9 commented on issue #12723: URL: https://github.com/apache/seatunnel/issues/12723#issuecomment-6183304393
@chovy-3012 Thanks for the confirmation — that matches what was asked for here: a single focused PR, REPEATED/STRUCT (including nested) covered in the reverse type-mapping tests, the exact validation error message for the read-mode rule spelled out in the PR description, and no new third-party dependency. One thing I don't see yet: the PR link itself hasn't been posted in this thread. Once it's up, please drop the link here so it can be tied to this issue. When you open it, a quick checklist against the earlier points so review goes fast: 1. **Type conversion:** the BigQuery → SeaTunnel mapping kept separate from the existing write-direction converter, with explicit tests for null, BYTES, NUMERIC/BIGNUMERIC, DATE/TIME/TIMESTAMP, REPEATED and STRUCT (nested included, as you confirmed). 2. **Option rule:** exactly one read mode — `query` alone, or the complete `dataset_id` + `table_id` pair — with both/neither rejected, and the error text quoted in the PR description. 3. **Lifecycle semantics:** query execution, direct-table pagination, job cleanup on close and the bounded at-least-once delivery described in the PR description and in the EN and ZH docs. 4. **E2E:** the source path added to the existing `connector-bigquery-e2e` suite, plus normal source registration and packaging. Nothing else is needed from my side right now — just the link when it's ready. <!-- streview-comment:1762 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
