chovy-3012 commented on issue #12723: URL: https://github.com/apache/seatunnel/issues/12723#issuecomment-6109296572
Thanks @DanielLeens for the review. Acknowledged on all four points: 1. **Type conversion:** The existing converter is write-direction only. I will implement a separate reverse mapping (BigQuery → SeaTunnel) and add explicit tests for null, BYTES, NUMERIC/BIGNUMERIC, DATE/TIME/TIMESTAMP, REPEATED, and STRUCT. 2. **Option rule:** The factory will require exactly one read mode — `query` alone, or the complete `dataset_id` + `table_id` pair — and reject the config when both or neither are supplied. 3. **Lifecycle semantics:** Query execution, pagination, job cleanup on close, and bounded-batch at-least-once delivery will be documented explicitly in the PR description and in EN/ZH docs. 4. **E2E:** I will extend the existing `connector-bigquery-e2e` suite for the source path rather than creating a new module. I will link the focused PR here once it is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
