xiangfu0 commented on code in PR #13217:
URL: https://github.com/apache/pinot/pull/13217#discussion_r1615335004
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -270,8 +253,7 @@ private TransferableBlock consumeAggregation() {
new FunctionContext(FunctionContext.Type.AGGREGATION, functionName,
arguments), true);
}
- private static AggregationFunction<?, ?>
getAggFunctionForIntermediateInput(RexExpression.FunctionCall functionCall,
- Map<Integer, Literal> literalArguments) {
+ private static AggregationFunction<?, ?>
getAggFunctionForIntermediateInput(RexExpression.FunctionCall functionCall) {
Review Comment:
The only difference is that first argument type in intermediate stage
function operands might be different than raw input stage.
For count(*), no argument in rawInput stage, but you need one InputRef in
the intermediate stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
