xiangfu0 commented on code in PR #13217:
URL: https://github.com/apache/pinot/pull/13217#discussion_r1615334327


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpressionUtils.java:
##########
@@ -248,9 +248,11 @@ private static List<RexExpression> 
toFunctionOperands(RexInputRef rexInputRef, S
   public static RexExpression fromAggregateCall(AggregateCall aggregateCall) {
     List<RexExpression> operands =
         
aggregateCall.getArgList().stream().map(RexExpression.InputRef::new).collect(Collectors.toList());
+    List<RexExpression> preArg =
+        
aggregateCall.rexList.stream().map(RexExpressionUtils::fromRexNode).collect(Collectors.toList());

Review Comment:
   This won't work for intermediate stage, which expects only one argument in 
the operand list with InputRef to the type of an intermediate object.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to