Jackie-Jiang commented on code in PR #13217:
URL: https://github.com/apache/pinot/pull/13217#discussion_r1615315761
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -270,8 +253,7 @@ private TransferableBlock consumeAggregation() {
new FunctionContext(FunctionContext.Type.AGGREGATION, functionName,
arguments), true);
}
- private static AggregationFunction<?, ?>
getAggFunctionForIntermediateInput(RexExpression.FunctionCall functionCall,
- Map<Integer, Literal> literalArguments) {
+ private static AggregationFunction<?, ?>
getAggFunctionForIntermediateInput(RexExpression.FunctionCall functionCall) {
Review Comment:
Should we use same way to process raw input and intermediate input since we
already have all operands?
Right you we assume we don't need function for raw input which is not always
true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
