Jackie-Jiang commented on code in PR #13217:
URL: https://github.com/apache/pinot/pull/13217#discussion_r1614794331
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java:
##########
@@ -162,7 +162,17 @@ public Object getValue() {
public boolean getBooleanValue() {
Boolean booleanValue = _booleanValue;
if (booleanValue == null) {
- booleanValue = _pinotDataType != null &&
_pinotDataType.toBoolean(_value);
+ if (_value instanceof Boolean) {
Review Comment:
The bug is on the `RexExpression` conversion side, where boolean value is
not properly preserved. We should change `RexExpressionUtils` to keep the value
type aligned with the data type. Also, if I read it correctly, `TIMESTAMP` is
also not properly handled as it is not supported within `LiteralContext` yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
