Copilot commented on code in PR #16335:
URL: https://github.com/apache/pinot/pull/16335#discussion_r2201895877
##########
pom.xml:
##########
@@ -421,6 +421,56 @@
</plugins>
</build>
</profile>
+ <!-- Apple Silicon Mac with Homebrew for protoc -->
+ <profile>
+ <id>macos-arm64-protobuf-homebrew</id>
+ <activation>
+ <os>
+ <family>mac</family>
+ <arch>aarch64</arch>
+ </os>
+ <file>
+ <exists>/opt/homebrew/bin/protoc-gen-grpc-java</exists>
+ </file>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
Review Comment:
The plugin configuration for both ARM64 profiles is nearly identical.
Consider extracting common settings into a <pluginManagement> section or using
a Maven property for the executable path to reduce duplication.
##########
pom.xml:
##########
@@ -421,6 +421,56 @@
</plugins>
</build>
</profile>
+ <!-- Apple Silicon Mac with Homebrew for protoc -->
+ <profile>
+ <id>macos-arm64-protobuf-homebrew</id>
+ <activation>
+ <os>
+ <family>mac</family>
+ <arch>aarch64</arch>
+ </os>
+ <file>
+ <exists>/opt/homebrew/bin/protoc-gen-grpc-java</exists>
+ </file>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.xolstice.maven.plugins</groupId>
+ <artifactId>protobuf-maven-plugin</artifactId>
Review Comment:
[nitpick] It may be safer to explicitly declare the <version> of the
protobuf-maven-plugin here to guarantee consistent behavior across all
environments.
```suggestion
<artifactId>protobuf-maven-plugin</artifactId>
<version>0.6.1</version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
