Copilot commented on code in PR #16335:
URL: https://github.com/apache/pinot/pull/16335#discussion_r2201845357
##########
pom.xml:
##########
@@ -421,6 +421,57 @@
</plugins>
</build>
</profile>
+ <!-- Apple Silicon Mac with Homebrew for protoc -->
+ <profile>
+ <id>macos-arm64-protobuf-homebrew</id>
+ <activation>
+ <os>
+ <family>mac</family>
+ <arch>aarch64</arch>
+ </os>
+ <file>
+ <exists>/opt/homebrew/bin/protoc-gen-grpc-java</exists>
+ <missing>/usr/local/bin/protoc-gen-grpc-java</missing>
Review Comment:
Requiring both <exists> and <missing> means if the plugin is installed in
both paths, neither profile will activate. Consider using only <exists> or a
different activation strategy so at least one profile always applies.
```suggestion
```
##########
pom.xml:
##########
@@ -421,6 +421,57 @@
</plugins>
</build>
</profile>
+ <!-- Apple Silicon Mac with Homebrew for protoc -->
+ <profile>
+ <id>macos-arm64-protobuf-homebrew</id>
+ <activation>
+ <os>
+ <family>mac</family>
+ <arch>aarch64</arch>
+ </os>
+ <file>
+ <exists>/opt/homebrew/bin/protoc-gen-grpc-java</exists>
+ <missing>/usr/local/bin/protoc-gen-grpc-java</missing>
+ </file>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.xolstice.maven.plugins</groupId>
+ <artifactId>protobuf-maven-plugin</artifactId>
+ <configuration>
+
<pluginExecutable>/opt/homebrew/bin/protoc-gen-grpc-java</pluginExecutable>
Review Comment:
The <pluginExecutable> configuration is duplicated in both profiles.
Consider defining a Maven property and referencing it to reduce duplication.
```suggestion
<pluginExecutable>${protoc.gen.grpc.java.homebrew}</pluginExecutable>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
