Copilot commented on code in PR #16335:
URL: https://github.com/apache/pinot/pull/16335#discussion_r2201858629
##########
pom.xml:
##########
@@ -421,6 +421,62 @@
</plugins>
</build>
</profile>
+ <!-- Apple Silicon Mac with Homebrew for protoc -->
+ <profile>
+ <id>macos-arm64-protobuf-homebrew</id>
+ <activation>
+ <os>
+ <family>mac</family>
+ <arch>aarch64</arch>
+ </os>
+ <file>
+ <exists>/opt/homebrew/bin/protoc-gen-grpc-java</exists>
+ </file>
+ </activation>
+ <properties>
+
<protoc.gen.grpc.java.homebrew>/opt/homebrew/bin/protoc-gen-grpc-java</protoc.gen.grpc.java.homebrew>
+ </properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.xolstice.maven.plugins</groupId>
+ <artifactId>protobuf-maven-plugin</artifactId>
+ <configuration>
+
<pluginExecutable>${protoc.gen.grpc.java.homebrew}</pluginExecutable>
+ </configuration>
Review Comment:
[nitpick] The `<plugin>` configuration block is duplicated in both profiles;
you might centralize the shared plugin settings (groupId, artifactId, version)
and only override the `pluginExecutable` property per profile to reduce
duplication.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
