Copilot commented on code in PR #16335:
URL: https://github.com/apache/pinot/pull/16335#discussion_r2201822545
##########
pom.xml:
##########
@@ -421,6 +421,83 @@
</plugins>
</build>
</profile>
+ <!-- Apple Silicon Mac with Homebrew for protoc -->
+ <profile>
+ <id>macos-arm64-protobuf-homebrew</id>
+ <activation>
+ <os>
+ <family>mac</family>
+ <arch>aarch64</arch>
+ </os>
+ <file>
+ <exists>/opt/homebrew/bin/protoc-gen-grpc-java</exists>
+ </file>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.xolstice.maven.plugins</groupId>
+ <artifactId>protobuf-maven-plugin</artifactId>
+ <version>0.6.1</version>
+ <configuration>
+
<protocArtifact>com.google.protobuf:protoc:${protobuf.version}:exe:${os.detected.classifier}</protocArtifact>
+ <pluginId>grpc-java</pluginId>
+
<pluginArtifact>io.grpc:protoc-gen-grpc-java:${grpc.version}:exe:${os.detected.classifier}</pluginArtifact>
+
<pluginExecutable>/opt/homebrew/bin/protoc-gen-grpc-java</pluginExecutable>
+ </configuration>
+ <executions>
+ <execution>
+ <goals>
+ <goal>compile</goal>
+ <goal>compile-custom</goal>
+ <goal>test-compile</goal>
+ <goal>test-compile-custom</goal>
+ </goals>
+ </execution>
+ </executions>
Review Comment:
[nitpick] The plugin configuration is duplicated across two profiles;
consider extracting the common protobuf-maven-plugin configuration into a
shared section or pluginManagement block and parameterizing only the
pluginExecutable path.
```suggestion
<configuration>
<pluginExecutable>/opt/homebrew/bin/protoc-gen-grpc-java</pluginExecutable>
</configuration>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
