raiden00pl commented on code in PR #10828:
URL: https://github.com/apache/nuttx/pull/10828#discussion_r1342799633


##########
arch/Kconfig:
##########
@@ -502,7 +502,8 @@ config ARCH_HAVE_PERF_EVENTS
 
 config ARCH_PERF_EVENTS
        bool "Configure hardware performance counting"
-       default y
+       default y if SCHED_CRITMONITOR || SCHED_IRQMONITOR || RPTUN_PING || 
SEGGER_SYSVIEW

Review Comment:
   If we set the default ARCH_PERF_EVENTS to n then the default source for perf 
will be systime which usually has poor resolution.  In this case, some of the 
debugging functions will be useless (eg. systemview). I think this may cause 
problems for users. That's why I think ARCH_PERF_EVENTS=y should be y when some 
debug features are enabled
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to