xiaoxiang781216 commented on code in PR #10828: URL: https://github.com/apache/nuttx/pull/10828#discussion_r1341443709
########## arch/Kconfig: ########## @@ -502,7 +502,8 @@ config ARCH_HAVE_PERF_EVENTS config ARCH_PERF_EVENTS bool "Configure hardware performance counting" - default y + default y if SCHED_CRITMONITOR || SCHED_IRQMONITOR || RPTUN_PING || SEGGER_SYSVIEW Review Comment: after #10384, all perf component doesn't depend on ARCH_PERF_EVENTS anymore, so I think we can simply change the default value to n without if statement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org