raiden00pl commented on code in PR #10828:
URL: https://github.com/apache/nuttx/pull/10828#discussion_r1339905867
##########
arch/Kconfig:
##########
@@ -498,7 +502,7 @@ config ARCH_HAVE_PERF_EVENTS
config ARCH_PERF_EVENTS
bool "Configure hardware performance counting"
- default y
+ default y if ARCH_NEED_PERF
Review Comment:
`ARCH_HAVE_PERF_EVENTS` informs whether arch supports `ARCH_PERF_EVENTS`.
`ARCH_PERF_EVENTS` enables arch specific `up_perf_xxx`. But according to
c928acc9ffed574b139d7508a1338ce71d772291 you can have `ARCH_PERF_EVENTS`
supported in arch but still use a different `up_perf_xxx` implementation.
So the currently available flags serve a different purpose than what is
needed here.
We need here a flag that is set when any system component needs perf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
