[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10828: arch: add a flag indicating that we need up_perf_xxx

[via GitHub]

xiaoxiang781216 commented on code in PR #10828:
URL: https://github.com/apache/nuttx/pull/10828#discussion_r1339856656


##########
arch/Kconfig:
##########
@@ -498,7 +502,7 @@ config ARCH_HAVE_PERF_EVENTS
 
 config ARCH_PERF_EVENTS
        bool "Configure hardware performance counting"
-       default y
+       default y if ARCH_NEED_PERF

Review Comment:
   why need a new option? if we already have ARCH_HAVE_PERF_EVENTS and 
ARCH_PERF_EVENTS.R



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org