[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7572: tools: Fix various error in Windows native build

[GitBox]

pkarashchenko commented on code in PR #7572:
URL: https://github.com/apache/incubator-nuttx/pull/7572#discussion_r1020605713


##########
libs/libc/Makefile:
##########
@@ -115,7 +115,7 @@ endif
 BINDIR ?= bin
 
 AOBJS = $(patsubst %.S, $(BINDIR)$(DELIM)%$(OBJEXT), $(ASRCS))
-COBJS = $(patsubst %.c, $(BINDIR)$(DELIM)%$(OBJEXT), $(CSRCS))
+COBJS = $(patsubst %.c, $(BINDIR)/%$(OBJEXT), $(CSRCS))

Review Comment:
   `tools/Config.mk` has:
   ```
   # DELIM - Path segment delimiter character
   #
   # Depends on this settings defined in board-specific defconfig file installed
   # at $(TOPDIR)/.config:
   #
   #   CONFIG_WINDOWS_NATIVE - Defined for a Windows native build
   
   ifeq ($(CONFIG_WINDOWS_NATIVE),y)
     DELIM ?= $(strip \)
   else
     DELIM ?= $(strip /)
   endif
   ```
   Isn't this still the case for Windows?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org