xiaoxiang781216 commented on code in PR #7572:
URL: https://github.com/apache/incubator-nuttx/pull/7572#discussion_r1020229249
##########
libs/libc/Makefile:
##########
@@ -194,9 +196,9 @@ distclean:: clean
$(Q) $(MAKE) -C kbin distclean
$(Q) $(MAKE) -C zoneinfo distclean BIN=$(BIN)
$(call DELFILE, exec_symtab.c)
- $(call DELFILE, bin/Make.dep)
- $(call DELFILE, kbin/Make.dep)
+ $(call DELFILE, bin$(DELIM)Make.dep)
Review Comment:
why mix / and $(DELIM)
##########
libs/libc/Makefile:
##########
@@ -115,7 +115,7 @@ endif
BINDIR ?= bin
AOBJS = $(patsubst %.S, $(BINDIR)$(DELIM)%$(OBJEXT), $(ASRCS))
-COBJS = $(patsubst %.c, $(BINDIR)$(DELIM)%$(OBJEXT), $(CSRCS))
+COBJS = $(patsubst %.c, $(BINDIR)/%$(OBJEXT), $(CSRCS))
Review Comment:
why not use $(DELIM)
##########
tools/mkdeps.c:
##########
@@ -443,12 +446,13 @@ static void parse_args(int argc, char **argv)
* do_dependency() uses them as bare filenames as well.
* (In addition to passing them to system().)
*/
-
+#ifndef CONFIG_WINDOWS_NATIVE
if (group == 1)
{
arg = do_shquote(arg);
Review Comment:
If so, let's remove quote for linux too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
