zouboan commented on code in PR #7572: URL: https://github.com/apache/incubator-nuttx/pull/7572#discussion_r1020236729
########## libs/libc/Makefile: ########## @@ -115,7 +115,7 @@ endif BINDIR ?= bin AOBJS = $(patsubst %.S, $(BINDIR)$(DELIM)%$(OBJEXT), $(ASRCS)) -COBJS = $(patsubst %.c, $(BINDIR)$(DELIM)%$(OBJEXT), $(CSRCS)) +COBJS = $(patsubst %.c, $(BINDIR)/%$(OBJEXT), $(CSRCS)) Review Comment: #1088 remove the line `DELIM := $(strip /)` in libs/libc/Makefile `# REVISIT: Backslash causes problems in $(COBJS) target` `DELIM := $(strip /)` `BINDIR ?= bin` `AOBJS = $(patsubst %.S, $(BINDIR)$(DELIM)%$(OBJEXT), $(ASRCS))` `COBJS = $(patsubst %.c, $(BINDIR)$(DELIM)%$(OBJEXT), $(CSRCS))` And in Windows native build give an error: `makefile:132: *** target mode do not include“%”. stop.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
