zouboan commented on code in PR #7572: URL: https://github.com/apache/incubator-nuttx/pull/7572#discussion_r1020620602
########## libs/libc/Makefile: ########## @@ -115,7 +115,7 @@ endif BINDIR ?= bin AOBJS = $(patsubst %.S, $(BINDIR)$(DELIM)%$(OBJEXT), $(ASRCS)) -COBJS = $(patsubst %.c, $(BINDIR)$(DELIM)%$(OBJEXT), $(CSRCS)) +COBJS = $(patsubst %.c, $(BINDIR)/%$(OBJEXT), $(CSRCS)) Review Comment: > Isn't this still the case for Windows? Windows is not a GNU environment, in Windows native build, we must use some GNU command(from GnuWin32) to support makefile, some special cases we must use `/` rather than Backslash. libs/libc/Makefile and mm/Makefile is the special cases,to resolve the probled in $(COBJS) target caused by backslash , we must use `/` in $(COBJS) of `libs/libc` and `mm` although In most cause we use `\` in Windows native build. please look at commit https://github.com/apache/incubator-nuttx/commit/e10ab85d1d39950d719a4bd7d2379c01d8c59a28 **More changes to restore the native Windows build** gregroy add this two line **especially**: `# REVISIT: Backslash causes problems in $(COBJS) target` `DELIM := $(strip /)` in `libc/Makefile` and `mm/Makefile` to restore the native Windows build it means that use `/` in Windows native build as well as in Linux environment, although In most cause should use `\` in Windows native build. `DELIM := $(strip /)` was removed from `libc/Makefile` and `mm/Makefile` in #1088 and result use `\` libs in Windows native build in `libc/Makefile` and `mm/Makefile` ,which broke Windows native build and give an error: `makefile:132: *** target mode do not include“%”. stop.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
