zouboan commented on code in PR #7572:
URL: https://github.com/apache/incubator-nuttx/pull/7572#discussion_r1020199752
##########
libs/libc/Makefile:
##########
@@ -194,9 +196,9 @@ distclean:: clean
$(Q) $(MAKE) -C kbin distclean
$(Q) $(MAKE) -C zoneinfo distclean BIN=$(BIN)
$(call DELFILE, exec_symtab.c)
- $(call DELFILE, bin/Make.dep)
- $(call DELFILE, kbin/Make.dep)
+ $(call DELFILE, bin$(DELIM)Make.dep)
+ $(call DELFILE, kbin$(DELIM)Make.dep)
$(call DELFILE, .depend)
--include bin/Make.dep
--include kbin/Make.dep
+-include bin$(DELIM)Make.dep
Review Comment:
> Sorry for the confusion. It was more a general question not related to
this line directly. I see many places that replace `DELIM` with `/`, so
wondering why that is done?
#1088 remove the line `DELIM := $(strip /)` in libs/libc/Makefile
`
# REVISIT: Backslash causes problems in $(COBJS) target
DELIM := $(strip /)
BINDIR ?= bin
AOBJS = $(patsubst %.S, $(BINDIR)$(DELIM)%$(OBJEXT), $(ASRCS))
COBJS = $(patsubst %.c, $(BINDIR)$(DELIM)%$(OBJEXT), $(CSRCS))
`
And in Windows native build give an error:
`makefile:132: *** target mode do not include“%”. stop.`
ditto mm/Makefile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
