masayuki2009 commented on PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1277481868
>@masayuki2009 ok, the change split into two patch, please review again.
@xiaoxiang781216
Thanks for the changes.
As far as I can see, the first commit still contains several intentions.
For example, in `cxd56_emmc.c` you did the following changes which just
replace `emmc_takesem` with `nxsem_wait_uninterruptible` and `emmc_givesem`
with `nxsem_post`. However, these changes do NOT replace the nxsem with the
nxmutex. Actually, I can see similar changes in cxd56_farapi.c and other
files. So, these changes should be separated into another commit too.
```
static void emmc_cmdstarted(void)
{
uint32_t val;
@@ -429,7 +420,7 @@ static void emmc_send(int datatype, uint32_t opcode,
uint32_t arg,
/* Wait for command or data transfer done */
- ret = emmc_takesem(&g_waitsem);
+ ret = nxsem_wait_uninterruptible(&g_waitsem);
if (ret < 0)
{
return;
@@ -592,8 +583,7 @@ static int emmc_interrupt(int irq, void *context, void
*arg)
ferr("End-bit error/write no CRC.\n");
}
- emmc_givesem(&g_waitsem);
-
+ nxsem_post(&g_waitsem);
return OK;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
