xiaoxiang781216 commented on PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1277528793
> > @masayuki2009 ok, the change split into two patch, please review again. > > @xiaoxiang781216 Thanks for the changes. As far as I can see, the first commit still contains several intentions. > > For example, in `cxd56_emmc.c` you did the following changes which just replace `emmc_takesem` with `nxsem_wait_uninterruptible` and `emmc_givesem` with `nxsem_post`. However, these changes do NOT replace the nxsem with the nxmutex. Actually, I can see similar changes in cxd56_farapi.c and other files. So, these changes should be separated into another commit too. As I said before, this patch want to distinguish sem_t usage which contain two part: 1. If sem is used as lock, change the variable name to lock and call nxmutex_lock/nxmutex_unlock 2. If sem is used as event/count, keep the variable name and call nxsem_wait_uninterruptible/nxsem_post instead _takesem/_givesem If without the second part, takesem/givesem give reader expression that sem is still used as lock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
