xiaoxiang781216 commented on PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1278384108
> > The change is already simple and consistent now, it's very error prone and time consuming to split the change into two commit again. @pkarashchenko and I already spend a lot of time to review and refine the change. Please respect our work, especially many code is vendor specific. I already spend many time to improve the code that I don't really use. If you insist I have to drop all code that I don't care about from this patch. > > @xiaoxiang781216 @pkarashchenko Thank you for your comments and efforts so far. OK, I understand the current situation. However, when you create a new PR next time, please consider dividing a commit into smaller ones that are independent. Reviewing each commit file will be much easier to find any simple mistake. Sure, thanks for suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
