xiaoxiang781216 commented on PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1276949593
> > @masayuki2009 @pkarashchenko the style change is revert, please review again. > > @xiaoxiang781216 Thanks for your efforts and updates. > > It seems much easier to check the differences but I still have some comments. In my understanding, this PR is intended to replace binary semaphore usage with nxmutex. However, I can see some other changes like critical section with nxsem (e.g. cxd56_i2c.c) and nxsem to nxsem (i.e. cxd56_icc.c). I think that kind of changes should not be mixed in this PR. nxmutex_t is initialized directly at the variables(g_i2cxdev) definition, not in cxd56_i2cbus_initialize, and then the code can be protected by mutex_t self, so it's redundancy to use the critical section here. That's why the patch remove the critical section too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
