xiaoxiang781216 commented on a change in pull request #5148:
URL: https://github.com/apache/incubator-nuttx/pull/5148#discussion_r777802724
##########
File path: arch/risc-v/src/common/riscv_assert.c
##########
@@ -57,6 +57,14 @@
# define CONFIG_BOARD_RESET_ON_ASSERT 0
#endif
+/* Format output with register width and hex */
+
+#ifdef CONFIG_ARCH_RV32
+# define PRIxREG "8"PRIx32
Review comment:
yes, but we can check `__LP64__` like what's is done in
nuttx/arch/risc-v/include/types.h. The final goal is to remove CONFIG_ARCH_RV32
from Kconfig.
And PRIxPTR is better than PRIx32/PRIx64 since the type pass to _alert is
uinptr_t.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
