no1wudi commented on a change in pull request #5148:
URL: https://github.com/apache/incubator-nuttx/pull/5148#discussion_r777804499
##########
File path: arch/risc-v/src/common/riscv_assert.c
##########
@@ -57,6 +57,14 @@
# define CONFIG_BOARD_RESET_ON_ASSERT 0
#endif
+/* Format output with register width and hex */
+
+#ifdef CONFIG_ARCH_RV32
+# define PRIxREG "8"PRIx32
Review comment:
OK, but I thinks it's better to keep this Symbol for some reason :
1. SoC still need to specific it's register width
2. This symbol from nuttx/config.h can provide better support for modern
editor (like language server in vscode) since `__LP64__` series definition
only available in riscv relative toolchain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
