raiden00pl commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-761753545
1. I still don't get why we should use the DMA list anywhere. Repeated start works by default and there is no problem with that. We trigger STARTTX for each I2C message, so new START is sent. The DMA list can be useful when all outgoing messages have the same length. But that is not our case. Anyway, what this DMA mode does is just automatic data PTR incrementing, nothing more. 2. In my experience, this is not a rarely required feature, but quite the opposite. We should be careful with making decisions based on our subjective experiences as they can vary greatly. This feature should be supported in some way. Getting rid of it completely is the worst option. I still think it should be on by default, but I won't insist. My reasoning is as follows. 1. The NOSTART/NOSTOP flags are the basic functionality required by the I2C interface from the I2C lower-half implementation. 2. Disabling support for them is only an additional optimization of the system. 3. Basic system features should be enabled by default. 4. Additional system optimizations should be disabled by default. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
