btashton commented on a change in pull request #1661:
URL: https://github.com/apache/incubator-nuttx/pull/1661#discussion_r479658212
##########
File path: include/netpacket/bluetooth.h
##########
@@ -286,6 +271,13 @@ struct sockaddr_bt_s
uint8_t bt_channel; /* Channel identifier (CID) */
};
+struct sockaddr_hci_s
+{
+ sa_family_t hci_family;
+ uint8_t hci_dev;
+ uint8_t hci_channel;
+};
+
Review comment:
I'm kind of aiming somewhere in the middle. I was also wondering if I
should rename the struct or not, I think keeping the members the same is
important.
Adapting L2CAP to the Linux addr interface is what I would also like, but I
am not focusing too much on that yet.
This also brings up the question of how much existing compatibility is ok to
break in the spirit of better aligning with the "standard".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
