patacongo commented on a change in pull request #1661:
URL: https://github.com/apache/incubator-nuttx/pull/1661#discussion_r479578762



##########
File path: net/socket/socket.c
##########
@@ -86,6 +86,7 @@ int psock_socket(int domain, int type, int protocol,
 
   psock->s_crefs  = 1;
   psock->s_domain = domain;
+  psock->s_proto = protocol;

Review comment:
       > 
   > 
   > It is done a few lines down from here once the flags are stripped from the 
argument.
   
   OK.  Good.  hard to see that through the peephole of diff's.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to